Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: select project by role #159

Merged
merged 2 commits into from
Nov 23, 2023
Merged

feat: select project by role #159

merged 2 commits into from
Nov 23, 2023

Conversation

david-code
Copy link
Contributor

Description

  • Needed to export one of the selectors that I was already using to map user role to project
  • Realized in this process, re-reading the redux docs, that the selector was not defined properly, so had to refactor it a bit. The problem was that an intermediary selector was essentially creating a new object, which is not the way the intermediary selector are supposed to work. I separated out the function work and used it in the final selector.
  • Changed the tests to adapt to the fact that the refactored selectors use the current user ID, instead of having to provide it explicitly.

Checklist

  • Corresponding issue has been opened
  • New tests added

Related Issues

Related to techmatters/terraso-mobile-client#143

Verification steps

@david-code david-code changed the title Feat/select project by role feat: select project by role Nov 9, 2023
@david-code david-code merged commit cc96650 into main Nov 23, 2023
9 of 10 checks passed
@david-code david-code deleted the feat/select-project-by-role branch November 23, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants