fix: Restrict site transfer sites to projects where user is manager

techmatters · Feb 7, 2024 · 4ff2018 · 4ff2018
1 parent 8ba0502
commit 4ff2018
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/src/selectors.ts b/src/selectors.ts
@@ -123,11 +123,14 @@ export const selectSitesAndUserRoles = createSelector(
 );
 
 export const selectProjectsWithTransferrableSites = createSelector(
-  [selectProjectsWithUserRole, selectSites],
-  (projects, sites) => {
+  [selectProjectsWithUserRole, selectSites, selectSitesAndUserRoles],
+  (projects, sites, sitesWithRoles) => {
     const projectSites = projects.flatMap(project =>
       Object.keys(project.sites)
-        .filter(siteId => siteId in project.sites)
+        .filter(
+          siteId =>
+            siteId in project.sites && sitesWithRoles[siteId] === 'manager',
+        )
         .map(siteId => {
           const joinedSite = sites[siteId];