refactor: (from PR feedback) consolidate if logic + add detail to com…

…ment
techmatters · May 31, 2024 · 3b6cfac · 3b6cfac
1 parent f2b9538
commit 3b6cfac
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/soilId/soilIdService.ts b/src/soilId/soilIdService.ts
@@ -33,6 +33,8 @@ export const fetchSoilMatches = async ({
 }) => {
   /*
    * Depending on the given input parameters, one of the two APIs needs to be queried.
+   * Sites with data use the "data based" soil matches API, as it can use soil data and location
+   * Temporary locations use the "location based" soil matches API, only using location
    */
   if (siteId && soilData) {
     return fetchDataBasedSoilMatches(coords, soilDataToIdInput(soilData)).then(

diff --git a/src/utils.ts b/src/utils.ts
@@ -49,10 +49,8 @@ export const isEquivalentCoords = (a?: Coords, b?: Coords): boolean => {
       a.latitude.toFixed(5) === b.latitude.toFixed(5) &&
       a.longitude.toFixed(5) === b.longitude.toFixed(5)
     );
-  } else if (a === undefined && b === undefined) {
-    return true;
   } else {
-    return false;
+    return a === undefined && b === undefined;
   }
 };