-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Group membership list #980
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josebui
commented
Nov 15, 2023
if not default_group: | ||
print(f"no default group for landscape {landscape.name}") | ||
continue | ||
current_memberships = default_group.group.memberships.filter( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
todo: verify this
Groups verification query: WITH Counts AS (
SELECT
g.slug,
g.membership_type AS group_type,
g.enroll_method AS group_method,
cml.membership_type AS type,
cml.enroll_method AS method,
COUNT(gm.id) AS items_in_group,
COUNT(cm.id) AS items_in_membership_list
FROM
core_group g
LEFT JOIN
core_membership gm ON (gm.group_id = g.id AND gm.deleted_at is NULL)
LEFT JOIN
collaboration_membershiplist cml ON (cml.id = g.membership_list_id)
LEFT JOIN
collaboration_membership cm ON cml.id = cm.membership_list_id
GROUP BY
g.slug, g.membership_type, g.enroll_method, cml.membership_type, cml.enroll_method
)
SELECT
slug,
group_type,
type,
group_method,
method,
items_in_group,
items_in_membership_list
FROM
Counts
WHERE
items_in_group != items_in_membership_list OR group_type != type OR group_method != method; |
josebui
changed the base branch from
main
to
refactor/landscape-group-membership-list
November 20, 2023 22:35
josebui
changed the base branch from
refactor/landscape-group-membership-list
to
main
November 20, 2023 22:35
Co-authored-by: Paul Schreiber <[email protected]>
…hip_mutations.py Co-authored-by: Paul Schreiber <[email protected]>
Co-authored-by: Paul Schreiber <[email protected]>
josebui
force-pushed
the
refactor/group-membership-list
branch
from
November 22, 2023 15:42
7940fc1
to
6061f89
Compare
Final PR: #997 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Related Issues
Fixes #....
Verification steps