refactor: Link landscapes directly to shared files, links and visualizations #904
Conversation
josebui
force-pushed
the
refactor/landscapes-shared-files
branch
from
1444cc8 to
2a351b3
Compare
| def is_user_allowed_to_view_data_entry(data_entry, user): | ||
| shared_resources = data_entry.shared_resources.all() | ||
| for shared_resource in shared_resources: | ||
| if is_target_member(user, shared_resource.target): | ||
| return True | ||
| return False |
There was a problem hiding this comment.
question: can there be a case where there are multiple shared resources and the user is only a member of one of them? what happens then?
There was a problem hiding this comment.
@paulschreiber Yes, that can happen, so if the user has access to at least one of the targets where the resource is shared they can view it, that is why the algorithm exists early inside the for loop if the user is a member of any target.
| group = Group.objects.get(slug=group_slug) | ||
| except Group.DoesNotExist: | ||
| target = model_class.objects.get(slug=target_slug) | ||
| except Exception: |
There was a problem hiding this comment.
question: can you specify a more specific exception type?
| def resolve_source(self, info, **kwargs): | ||
| return self.source | ||
|
|
||
| def resolve_target(self, info, **kwargs): | ||
| return self.target |
There was a problem hiding this comment.
question: Curious why these resolve methods are necessary, is this something to do with the ContentType model?
There was a problem hiding this comment.
@david-code Yes, this has to do with the generic relationship, graphene is not able to do this automatically so it expects this to be defined explicitely
…re specific exception
josebui
force-pushed
the
refactor/landscapes-shared-files
branch
from
8800c53 to
ed3430a
Compare
Description
Link landscapes directly to shared files, links and visualizations
Checklist
Related Issues
Related PRs