Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add filter option to UserNode to filter users based on projects to which they belong #845

Merged
merged 3 commits into from
Oct 4, 2023

Conversation

david-code
Copy link
Contributor

@david-code david-code commented Sep 29, 2023

Adds a filter field on the UserNode that allows a client to filter users based on if they belong to a given project. This will be used by the mobile client to query if a user can be added to a given project.

Description

Checklist

  • Corresponding issue has been opened
  • New tests added

Related Issues

Related to techmatters/terraso-mobile-client#37

Verification steps

Adds a filter field on the UserNode that allows a client to filter
users based on if they belong to a given project. This will be used by
the mobile client to query if a user can be added to a given project.
Django Graphene / Django Filters have a slightly different interface
for declaring filter fields on DjangoObjectType and FilterSet.
@david-code david-code changed the title feat: Add option to filter users by project feat: Add filter option to UserNode to filter users based on projects to which they belong Oct 2, 2023
Copy link
Member

@shrouxm shrouxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple suggestions but looks good!

terraso_backend/apps/graphql/schema/users.py Outdated Show resolved Hide resolved
terraso_backend/apps/graphql/schema/users.py Outdated Show resolved Hide resolved
@david-code david-code merged commit 4929e5f into main Oct 4, 2023
6 checks passed
@david-code david-code deleted the feat/user-filter-by-project branch October 4, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants