feat: Ignore duplicate adding user to project #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The plan is to use the project info in the redux store in the app to determine if a user belongs to a project. This would create a corner case where a user might be added to the same project twice. (Actually, I think that would exist regardless). This commit just treats that case a succesful operation and does nothing.
shrouxm
approved these changes
Oct 3, 2023
Yep, that's right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For adding a user to a project, the plan is to use the project info in the redux store in the app to determine if a user belongs to a project. This would create a corner case where a user might be added to the same project twice. (Actually, I think that would exist regardless). This commit just treats that case a succesful operation and does nothing, which seems like the simplest solution to me. In the future we might want to return different error statuses if the user was already added.
Description
Checklist
Related Issues
Related somewhat to techmatters/terraso-mobile-client#37
Verification steps