Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: track whether sites and projects have been seen by users #813

Merged
merged 1 commit into from
Sep 26, 2023
Merged

feat: track whether sites and projects have been seen by users #813

merged 1 commit into from
Sep 26, 2023

Conversation

shrouxm
Copy link
Member

@shrouxm shrouxm commented Sep 14, 2023

Checklist

  • Corresponding issue has been opened
  • Tests added

Related Issues

Fixes #672

@shrouxm shrouxm marked this pull request as ready for review September 19, 2023 20:44
@shrouxm shrouxm requested a review from david-code September 19, 2023 20:44
david-code
david-code approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@david-code david-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. It might be a good idea to separate the duplicated code out into a separate mixin class.

@shrouxm shrouxm merged commit 98bcf54 into main Sep 26, 2023
6 checks passed
@shrouxm shrouxm deleted the feat/sites-projects-seen-by-user branch September 26, 2023 15:58
@shrouxm shrouxm mentioned this pull request Sep 26, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-code david-code david-code approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Track if projects and sites have been seen by user
2 participants
@shrouxm @david-code