Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Async execution of update profile image #1414

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

josebui
Copy link
Contributor

@josebui josebui commented Aug 15, 2024

Description

Created async task to run profile image update

Checklist

  • Corresponding issue has been opened
  • New tests added

Related Issues

@josebui josebui self-assigned this Aug 15, 2024
@josebui josebui marked this pull request as ready for review August 15, 2024 17:48
@josebui josebui requested a review from paulschreiber August 15, 2024 17:48
Copy link
Member

@paulschreiber paulschreiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Please confirm that when we upload a new image for a user, it replaces the old image (i.e. doesn't leave a dangling/orphaned image around).

terraso_backend/apps/storage/tasks.py Outdated Show resolved Hide resolved
@josebui
Copy link
Contributor Author

josebui commented Aug 16, 2024

@paulschreiber I checked in S3 and the image is being replaced

@josebui josebui merged commit 97a0e40 into main Aug 19, 2024
7 checks passed
@josebui josebui deleted the refactor/async-profile-image-update branch August 19, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants