Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update depth presets for Capri #1365

Merged
merged 4 commits into from
Jul 11, 2024
Merged

feat: Update depth presets for Capri #1365

merged 4 commits into from
Jul 11, 2024

Conversation

knipec
Copy link
Contributor

@knipec knipec commented Jul 10, 2024 •
edited
Loading

For depth presets:

  • remove LandPKS
  • add BLM monitoring standard
  • make NRCS the default
  • update tests
  • create a db migration that will update any sites or projects with "LANDPKS" depth preset to "CUSTOM" depth preset with no depth intervals.

Related Issues

Backend part to address #1541

@knipec knipec requested review from shrouxm and paulschreiber July 10, 2024 01:04
paulschreiber
paulschreiber approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@paulschreiber paulschreiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Suggested a name change. (You'll need to regenerate the .graphql file as well.

terraso_backend/apps/soil_id/models/__init__.py Outdated Show resolved Hide resolved
terraso_backend/apps/soil_id/models/__init__.py Outdated Show resolved Hide resolved
terraso_backend/apps/soil_id/models/project_soil_settings.py Outdated Show resolved Hide resolved
terraso_backend/apps/soil_id/models/project_soil_settings.py Outdated Show resolved Hide resolved
terraso_backend/apps/soil_id/models/soil_data.py Outdated Show resolved Hide resolved
terraso_backend/tests/graphql/mutations/test_soil_data.py Outdated Show resolved Hide resolved
terraso_backend/tests/graphql/mutations/test_soil_data.py Outdated Show resolved Hide resolved
terraso_backend/tests/graphql/mutations/test_soil_data.py Outdated Show resolved Hide resolved
@knipec knipec requested a review from tm-ruxandra July 11, 2024 22:04
shrouxm
shrouxm approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@shrouxm shrouxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

j'approve

@knipec knipec merged commit 10de141 into main Jul 11, 2024
7 checks passed
@knipec knipec deleted the feat/depth-presets branch July 11, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shrouxm shrouxm shrouxm approved these changes

@paulschreiber paulschreiber paulschreiber approved these changes

@tm-ruxandra tm-ruxandra Awaiting requested review from tm-ruxandra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@knipec @paulschreiber @shrouxm