fix: Update permissions for site contributors to match requirements #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulschreiber
approved these changes
Mar 27, 2024
|
@paulschreiber could you avoid deleting my comments when re-iterating the same point? it is valuable information if several people had to stop and think about what a line of code is doing |
|
@shrouxm I thought you had written you left a comment in the wrong place — was deleting it so you could move it to the right line. Apologies if I misunderstood. |
shrouxm
force-pushed
the
fix/site-contributors
branch
from
a059945 to
1eb0899
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix problems with site contributor permissions by granting the "change site" permission to project contributors. Restrict the name, privacy, and project id fields to owner/manager to maintain access restrictions parity with mobile client. Add test cases verifying new access controls.
Checklist
Related Issues
Fixes #843, #925, #851
Verification steps
Create a project and a site as one user, then add a second user to the site as a contributor. Verify that the second user can now update soil data, crack data, texture data. Verify that the second user cannot update the name or privacy, but that the first user still can.