fix: depth interval default methods #1188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
paulschreiber
approved these changes
Mar 6, 2024
| @@ -25,6 +25,7 @@ | |||
| from apps.project_management.graphql.projects import ProjectNode | |||
| from apps.project_management.models import Project, Site, sites | |||
| from apps.soil_id.models import SoilData | |||
| from apps.soil_id.models.project_soil_settings import ProjectSoilSettings | |||
There was a problem hiding this comment.
issue: this import causes a linter error. should we remove it, or do we need to make a change to use it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some small changes to the data model to handle subtle cases of depth interval default methods. Previously we were only storing true/false for whether an input method was enabled, now we also allow the input method to be unset. This is because there are actually three possible states for input methods being enabled: explicit yes, explicit no, and unspecified. I think there may be some even longer tail UX edge cases to consider, but this data model lets us handle more situations with less complexity created by manual data chasing.
Checklist
Related Issues
Related to techmatters/terraso-mobile-client#502