fix: update esd_url to edit_url (#1413)

* fix: update esd_url to edit_url * style: reformat code
techmatters · Aug 20, 2024 · a6be7ae · a6be7ae
1 parent 3b4471e
commit a6be7ae
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/terraso_backend/apps/soil_id/graphql/soil_id/resolvers.py b/terraso_backend/apps/soil_id/graphql/soil_id/resolvers.py
@@ -94,7 +94,7 @@ def resolve_ecological_site(ecological_site: dict):
         return EcologicalSite(
             name=ecological_site["ecoclassname"][0],
             id=ecological_site["ecoclassid"][0],
-            url=ecological_site["esd_url"][0],
+            url=ecological_site["edit_url"][0],
         )
 
 

diff --git a/terraso_backend/tests/soil_id/test_graphql_resolvers.py b/terraso_backend/tests/soil_id/test_graphql_resolvers.py
@@ -38,7 +38,7 @@
             },
             "siteDescription": "The Randall series consists of very deep, poorly drained, very slowly permeable soils that formed in clayey lacustrine sediments derived from the Blackwater Draw Formation of Pleistocene age. These nearly level soils are on the floor of playa basins 3 to 15 m (10 to 50 ft) below the surrounding plain and range in size from 10 to more than 150 acres. Slope ranges from 0 to 1 percent. Mean annual precipitation is 483 mm (19 in), and mean annual temperature is 15 degrees C (59 degrees F).",  # noqa: E501
         },
-        "esd": {"ESD": {"ecoclassid": "", "ecoclassname": "", "esd_url": ""}},
+        "esd": {"ESD": {"ecoclassid": "", "ecoclassname": "", "edit_url": ""}},
         "bottom_depth": {"0": 30, "1": 94, "2": 203},
         "texture": {"0": "", "1": "Clay loam", "2": float("nan")},
         "rock_fragments": {"0": 0, "1": "", "2": 0},
@@ -70,7 +70,7 @@
             },
             "siteDescription": "",
         },
-        "esd": {"ESD": {"ecoclassid": "", "ecoclassname": "", "esd_url": ""}},
+        "esd": {"ESD": {"ecoclassid": "", "ecoclassname": "", "edit_url": ""}},
         "bottom_depth": {"0": 30, "1": 97, "2": 147, "3": 203},
         "sand": {"0": 49.1, "1": 48.9, "2": 48.7, "3": 52.5},
         "clay": {"0": 20.2, "1": 27.6, "2": 32.1, "3": 29.8},
@@ -128,7 +128,7 @@
             },
             "siteDescription": "",
         },
-        "esd": {"ESD": {"ecoclassid": "", "ecoclassname": "", "esd_url": ""}},
+        "esd": {"ESD": {"ecoclassid": "", "ecoclassname": "", "edit_url": ""}},
         "bottom_depth": {"0": 30, "1": 97, "2": 147, "3": 203},
         "sand": {"0": 50.9, "1": 48.9, "2": 48.7, "3": 52.5},
         "clay": {"0": 19.1, "1": 27.6, "2": 32.1, "3": 29.8},
@@ -238,16 +238,17 @@ def test_resolve_soil_data():
 
 
 def test_resolve_ecological_site():
-    assert resolve_ecological_site({"ecoclassid": "", "ecoclassname": "", "esd_url": ""}) is None
+    assert resolve_ecological_site({"ecoclassid": "", "ecoclassname": "", "edit_url": ""}) is None
     assert (
-        resolve_ecological_site({"ecoclassid": [""], "ecoclassname": [""], "esd_url": [""]}) is None
+        resolve_ecological_site({"ecoclassid": [""], "ecoclassname": [""], "edit_url": [""]})
+        is None
     )
 
     result = resolve_ecological_site(
         {
             "ecoclassid": ["AX001X02X001"],
             "ecoclassname": ["Mesic Udic Riparian Forest"],
-            "esd_url": [""],
+            "edit_url": [""],
         }
     )