Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test flag for modica messages to point replies at a terst API to … #704

Merged
merged 8 commits into from
Nov 1, 2024

Conversation

stephenhand
Copy link
Collaborator

@stephenhand stephenhand commented Oct 18, 2024

Description

Checklist

  • Corresponding issue has been opened
  • New tests added
  • Feature flags / configuration added

Other Related Issues

None

Verification steps

AFTER YOU MERGE

  1. Cut a release tag using the GitHub workflow. Wait for it to complete and the notification to be posted in the #aselo-deploys Slack channel.
  2. Comment on the ticket with the release tag version AND any additional instructions required to configure an environment to test the changes.
  3. Only then move the ticket into the QA column in JIRA

You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P

@stephenhand stephenhand marked this pull request as draft October 18, 2024 09:03
@stephenhand stephenhand requested a review from GPaoloni October 18, 2024 15:38
@stephenhand stephenhand marked this pull request as ready for review October 21, 2024 10:08
Copy link
Collaborator

@GPaoloni GPaoloni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me!

It would be good to have any doc indicating how this is supposed to be used maybe? If that already exists dismiss this comment :P

@stephenhand
Copy link
Collaborator Author

Code looks good to me!

It would be good to have any doc indicating how this is supposed to be used maybe? If that already exists dismiss this comment :P

I was going to write something up after I got this merged :-)

@stephenhand stephenhand merged commit 4862624 into master Nov 1, 2024
6 checks passed
@stephenhand stephenhand deleted the CHI-3005-modica_test_mode branch November 1, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants