CHI-2818 queue transfer capacity workaround #657
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds explicit chat capacity reductions for worker with original task after a transfer. THis prevents a race condition where they can be assigned a new task before their chat capacity is decreased due to completing the task
Also adds an 'increaseUntilCapacityAvailable' mode for adjustChatCapactity that will keep increasing chat capacity until capacity becomes available or the max capacity is reached. I was concerened that 'double decreases' could leave a worker with too low a capacity to pull tasks in some scenarios so this works around that
Checklist
Other Related Issues
None
Verification steps
See ticket - ensure worker and queue transfer scenarios are working
Also, ensure that if a worker picks up 3 tasks, then transfers 1 away, they can still pull yet another from the queue.
AFTER YOU MERGE
You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P