Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHI-2818 queue transfer capacity workaround #657

Merged
merged 6 commits into from
Jul 29, 2024

Conversation

stephenhand
Copy link
Collaborator

@stephenhand stephenhand commented Jul 25, 2024

Description

Adds explicit chat capacity reductions for worker with original task after a transfer. THis prevents a race condition where they can be assigned a new task before their chat capacity is decreased due to completing the task

Also adds an 'increaseUntilCapacityAvailable' mode for adjustChatCapactity that will keep increasing chat capacity until capacity becomes available or the max capacity is reached. I was concerened that 'double decreases' could leave a worker with too low a capacity to pull tasks in some scenarios so this works around that

Checklist

  • Corresponding issue has been opened
  • New tests added
  • Feature flags / configuration added

Other Related Issues

None

Verification steps

See ticket - ensure worker and queue transfer scenarios are working

Also, ensure that if a worker picks up 3 tasks, then transfers 1 away, they can still pull yet another from the queue.

AFTER YOU MERGE

  1. Cut a release tag using the GitHub workflow. Wait for it to complete and the notification to be posted in the #aselo-deploys Slack channel.
  2. Comment on the ticket with the release tag version AND any additional instructions required to configure an environment to test the changes.
  3. Only then move the ticket into the QA column in JIRA

You are responsible for ensuring the above steps are completed. If you move a ticket into QA without advising what version to test, the QA team will assume the latest tag has the changes. If it does not, the following confusion is on you! :-P

Copy link
Contributor

@murilovmachado murilovmachado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@stephenhand stephenhand merged commit 4f8ece8 into master Jul 29, 2024
4 checks passed
@stephenhand stephenhand deleted the CHI-2818-queue_transfer_capacity_workaround branch July 29, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants