Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix destroy function #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix destroy function #10

wants to merge 1 commit into from

Conversation

dsparkplug
Copy link

The destroy function was not working at all. It was attempting to remove the data from the jquery collection rather than the instance.

This change removes the data from the instance and also removes the click event handler.

@dsparkplug
Copy link
Author

No idea why the build is failing

@hishamtj
Copy link

thank you for this fix! weirdly it is still not implemented even in the latest release of the plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsparkplug @hishamtj