78-media-playback-multiplatform #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implement custom back arrow fix detail screen flashing in dark mode
…ile isPlaying is true. mediaId parameter is added to the AudioItem model. This will be used also to open the detail screen directly from the notification. The idea is to format the media id like songbook||entry. Then we can open to the song entry directly. TBD We use the mediaId also to determine when the current page has changed. add DummyPlaybackController for android composable preview
add logic to navigate using the previous/next buttons, show songbook and number on the bottom controls
Fixes the issue where multiple controllers could be active at the same time. Similar to AndroidPlaybackController but only that playback is also stopped. Future improvement: continue the playback in the background. Look into iOS audio session
storing absolute path breaks the app on iOS as each update is installed in a different directory
odifek
force-pushed
the
78-media-playback-multiplatform
branch
from
fe927c6 to
660a21c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The the rest of the commits