Bug fixes + minor doc site improvements #39
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
docs/assets/styles/docs.css
Outdated
| /* .table-scroll code { | ||
| white-space: nowrap; | ||
| } */ | ||
|
|
There was a problem hiding this comment.
Should we just cut this?
docs/pages/components/dialog.md
Outdated
| | `default` confirmation | `primary` | `exclamation-circle` | | ||
| | `default` informational | `primary` | `info-circle` | |
There was a problem hiding this comment.
Should the defaults still be in there?
There was a problem hiding this comment.
Yes, they are two separate types of dialogs that should use the default variant. But your comment made me realize the table could be laid out more clearly, so I made an update!
slhinyc
force-pushed
the
SLH/dialog-spacing-fix
branch
from
3eeb267 to
4326907
Compare
|
@kathleenteamshares @kdonovan -- Could you both take a look at some recent additions to this PR? There was an additional component update that we needed to make & rather than cut this patch release first and open another PR, I added to this PR so that we can just wrap all the changes in a new minor release. Updated the main PR notes to reflect all the changes. TY both! 🙏 |
What's in this PR
textvariant ofsl-buttonto strip all padding so that it aligns better with other elements on the screen (Link in review app)sl-checkboxandsl-radiobug where acontainedcheckbox or radio had a hover state even when disabled (Link in review app)sl-dialogbody forannouncementvariant (Link in review app)sl-buttonbug where a disabled link (a) button still opens thehreflink (Link in review app)sl-dialogdocsSLIMpreview is selectedreflectistrueScreenshots of props table update
Old props table
Full table isn't visible without horizontal scroll
Updated props table
Updated styling & layout so that no scrolling is needed to see the full table