Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Spinner component bug in Safari #31

Merged
merged 3 commits into from
Feb 21, 2024
Merged

Fix Spinner component bug in Safari #31

merged 3 commits into from
Feb 21, 2024

Conversation

slhinyc
Copy link

@slhinyc slhinyc commented Feb 21, 2024

  • Fix for ForeignObject element not working as expected in Safari
  • Replaced element with svg circle and linearGradient combo.
  • Tested on Browserstack and on my own devices (MacBook, iPhone, iPad). Everything looks good except there are some inconsistencies between Browserstack & my local devices (see below for details). Also cannot verify that Safari on Windows 11 looks okay (page won't load).

Test details

Some inconsistencies and issues with Safari on Windows 11, but otherwise all good.

Tested locally (on my MacOS)

  • Safari
  • Arc
  • Firefox
  • Chrome

Tested in Browserstack

Windows 11

  • Edge 120
  • Firefox 120
  • Chrome 120
  • Opera 105
  • Safari 5.1
    • The entire doc site is broken on Safari 5 on Windows. Looks like the CSS isn't loading at all. Can only get the site to run locally. Shoelace.style and the Vercel review app won't open at all.

iOS

  • Safari on iPhone 12 & iPhone 15
  • Chrome on iPhone 15
  • Safari on iPad 8th gen
  • Chrome on iPad 8th gen
  • When I test with Browserstack on iPad Chrome and Safari, I'm seeing an odd CSS translate issue that inconsistently messes with the spinning animation. But when I test locally on my own iPad, everything works as expected

Android

  • Chrome on Galaxy S23
  • Chrome on Pixel 6 Pro
  • Edge on Pixel 6 Pro

@slhinyc slhinyc requested a review from CrookedGrin as a code owner February 21, 2024 16:31
Copy link

vercel bot commented Feb 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
shoelace ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 21, 2024 7:02pm

@slhinyc slhinyc requested a review from a team February 21, 2024 16:32
Copy link

@CrookedGrin CrookedGrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for jumping on this!

@slhinyc slhinyc merged commit a4367f5 into next Feb 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants