[#43] 캘린더 뷰 #47
Merged
[#43] 캘린더 뷰 #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Description - 캘린더 뷰 컴포넌트 배치 - dummy data 생성 - AppMonth Enum 생성 - KingFisher 설치 - View Transition 연결을 위해 CoverUserPhotoVC에 Navi init 함수 추가 - Calendar, Tracker Data Model struct 추가 ### Related Issue close team-popo#43
hyun99999
approved these changes
Oct 1, 2021
| } | ||
|
|
||
| func setCell(tracker: Tracker) { | ||
|
|
There was a problem hiding this comment.
나는 cell 을 초기화 할때 사용한다고 생각해서 initCell 로 설정했는데 어떤 걸루 통일할까?
There was a problem hiding this comment.
아항... 그럼 다 init으로 통일하는걸로 합시돠 !!
| static let cellSpacing: CGFloat = 12 | ||
| static let cellWidth = ( screenWidth - collectionViewSpacing - cellSpacing * 4 ) / 5 | ||
| static let cellHeight = cellWidth * 1.3 | ||
| } |
There was a problem hiding this comment.
기존의 코드도 이런식으로 한번 바꿔줘야겠어 👍 요거 리펙토링할게여
|
어라 지금 봤는데 충돌났네염 |
아뇨 그냥 깃헙에서 resolve할게요 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
close #43