🎉 채팅 관련 UI 및 로직 #96
Merged
🎉 채팅 관련 UI 및 로직 #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juyeon-park
approved these changes
Nov 22, 2023
| ) | ||
| })} | ||
| {messages.length === 0 && ( | ||
| <h1 className="text-red-500">채팅을 시작해보세요!</h1> |
There was a problem hiding this comment.
채팅방에 진입했을 때 메세지들이 있는데도 채팅을 시작해보세요 문구가 1초정도 보였다가 사라지는데 혹시 의도하신 건가요? 🤔
There was a problem hiding this comment.
아닙니다. api처리하면서 수정할 예정입니다!
| @@ -0,0 +1,13 @@ | |||
| { | |||
There was a problem hiding this comment.
webhint 하나 비활성화해서 저장됐나보네요
| interface Message { | ||
| text: string | ||
| createdAt: Timestamp | ||
| sender: string |
There was a problem hiding this comment.
sender에는 유저의 nickName이 들어가는 것으로 이해하면 될까요?
There was a problem hiding this comment.
아 근데 유저 닉네임 변경 가능하네요... 아이디로 바꿔야겠습니다. 감사합니다
| try { | ||
| await addDoc(messageRef, { | ||
| text: message, | ||
| sender: currentUser?.nickname ?? '익명', |
There was a problem hiding this comment.
익명이 필요한 경우가 있나요?? 채팅같은 경우 무조건 로그인 상태여야만 접근할 수 있다면 필요 없을 것 같아서요 (잘 모름) 🤔
There was a problem hiding this comment.
필요 없을 것 같습니다. 권한 처리하면서 처리 예정입니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- 목적
관련 티켓 번호: 271, 273
- 주요 변경 사항
기타 사항 (선택)
- 스크린샷 (선택)