Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 카드 컴포넌트 UI 버그, 무한 스크롤 버그 수정, 각 카드 컴포넌트 key 대신 value 렌더링 하기 #94

Merged
merged 5 commits into from
Nov 22, 2023
Merged

🐛 카드 컴포넌트 UI 버그, 무한 스크롤 버그 수정, 각 카드 컴포넌트 key 대신 value 렌더링 하기 #94

merged 5 commits into from
Nov 22, 2023

Conversation

doggopawer
Copy link
Contributor

- 목적

관련 티켓 번호: 270


- 주요 변경 사항

  • 카드 컴포넌트의 텍스트가 특정 길이를 넘어가면 UI가 깨지는 스타일 버그를 수정했습니다.
  • PriceRangeObjs를 각 카드 컴포넌트에 적용했습니다.
  • InterSectionObserver 높이로 인한 비동작 오류를 PAGE_SIZE를 10으로 설정하여 응급조치 했습니다.

기타 사항 (선택)


- 스크린샷 (선택)

@doggopawer doggopawer added the D-1 label Nov 21, 2023
@doggopawer doggopawer self-assigned this Nov 21, 2023
juyeon-park
juyeon-park approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@juyeon-park juyeon-park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

응급처치 빠르게 해주셔서 감사합니다 👍

@doggopawer doggopawer merged commit 016bcd7 into develop Nov 22, 2023
2 checks passed
@doggopawer doggopawer deleted the NABI-270 branch November 22, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juyeon-park juyeon-park juyeon-park approved these changes

Assignees

@doggopawer doggopawer

Labels
D-1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doggopawer @juyeon-park