Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 찜 페이지 목록 구현 #68

Merged
merged 7 commits into from
Nov 13, 2023
Merged

🎉 찜 페이지 목록 구현 #68

merged 7 commits into from
Nov 13, 2023

Conversation

juyeon-park
Copy link
Contributor

- 목적

관련 티켓 번호: 160, 161

  • mock api와 페이지 연결을 한꺼번에 했습니다!

- 주요 변경 사항

  • 동현님이 작성하신 무한스크롤 코드를 토대로 구현했습니다!
  • route 경로를 mypage안에 있는 mydibs로 할지 별개로 mydibs로 둘지 고민이 되네요

기타 사항 (선택)


- 스크린샷 (선택)

image

@juyeon-park juyeon-park self-assigned this Nov 11, 2023
Copy link
Contributor

@doggopawer doggopawer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

주연님 코드 작성하시느라 수고 하셨습니다!
저도 충돌 때문에 고생했는데 내일 다같이 머지하면서 충돌날게 살짝 두렵네요... : )

src/app/(root)/(routes)/mydibs/my-dibs-list/MyDibsList.tsx Outdated Show resolved Hide resolved
src/lib/msw/mocks/data/items.json Show resolved Hide resolved
Copy link
Collaborator

@oaoong oaoong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actions 결과를 다시 확인해주세요. -자동으로 작성됨-

@juyeon-park juyeon-park merged commit ec5c406 into develop Nov 13, 2023
2 checks passed
@juyeon-park juyeon-park deleted the NABI-161 branch November 13, 2023 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants