๐ ๊ฑฐ๋ ์ ์ ๋ก์ง ๊ตฌํ #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juyeon-park
added
์์
์ค
doggopawer
approved these changes
Nov 12, 2023
| </TabsList> | ||
| {['offer', 'poke'].map((type) => ( | ||
| {['OFFER', 'POKE'].map((type) => ( |
There was a problem hiding this comment.
๋จ ๋๊ฐ์ ๊ฐ์ ๋ ๋๋ง ํ๊ณ ์๋๋ฐ
๋๊ฐ ์ ๋๋ฉด ๊ทธ๋ฅ ํ์ด์ ์จ๋ ๋์ง ์์๊น์? ์ด์ ๊ฐ ๊ถ๊ธํฉ๋๋ค!
There was a problem hiding this comment.
Tab Content์ ๋ด์ฉ์ด ๋ง์์ ํ์ด์ ์ฐ์ง ์๊ณ map์ผ๋ก ๋ฌถ์์ต๋๋ค!
src/app/(root)/(routes)/items/[itemId]/components/trade-section/TradeSection.tsx
Show resolved
Hide resolved
| import { postSuggestion } from '@/services/suggest/suggest' | ||
| import { ItemSuggestion } from '@/types' | ||
|
|
||
| const useSuggestMutation = (toCardId: number, fromCardId: number) => { |
There was a problem hiding this comment.
useSuggestMutation ๊ฐ์ ๊ฒฝ์ฐ ๊ธฐ์กด ์ํ๋ฅผ ์
๋ฐ์ดํธ ํ๋๊ฒ์ผ๋ก ๋ณด์ด๋๋ฐ
ํจ์๋ช
์ useSuggestUpdateMutation์ผ๋ก ํ๋๊ฒ ๋ ์ข์ ๊ฒ ๊ฐ์ต๋๋ค!
Comment on lines
+27
to
+33
| const indexToUpdate = previousSuggestions.findIndex( | ||
| (suggestion) => suggestion.cardId === fromCardId, | ||
| ) | ||
| updateSuggestions[indexToUpdate].suggestionStatus = 'WAITING' | ||
| queryClient.setQueryData(queryKey, updateSuggestions) | ||
|
|
||
| return { previousSuggestions } |
There was a problem hiding this comment.
ํน์ UI๊ฐ ๋ฐ๋์ง ์๋ ์ด์๊ฐ ํด๊ฒฐ๋์ จ๋์?
There was a problem hiding this comment.
๋ต!! ํด๊ฒฐ๋์์ต๋๋ค. ์๋ณธ ๋ฐ์ดํฐ๋ฅผ ๊น์ ๋ณต์ฌํ์ฌ ํด๊ฒฐํ์์ต๋๋ค.
oaoong
requested changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- ๋ชฉ์
๊ด๋ จ ํฐ์ผ ๋ฒํธ: 163
- ์ฃผ์ ๋ณ๊ฒฝ ์ฌํญ
๊ธฐํ ์ฌํญ (์ ํ)
- ์คํฌ๋ฆฐ์ท (์ ํ)