Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ 찜 API 업데이트 버전으로 msw 수정 #50

Merged
merged 1 commit into from
Nov 8, 2023
Merged

✨ 찜 API 업데이트 버전으로 msw 수정 #50

merged 1 commit into from
Nov 8, 2023

Conversation

juyeon-park
Copy link
Contributor

@juyeon-park juyeon-park commented Nov 7, 2023 •
edited
Loading

- 목적

관련 티켓 번호: 156


- 주요 변경 사항

  • 6번 API 명세서에서 찜 관련된 정보 총 2개를 보내주는 것으로 업데이트 되었습니다
    • isMyDib : 내가 찜한 상태인지에 대한 유무 boolean
    • dibsCount: 찜 개수 number

기타 사항 (선택)

  • 총 걸린 시간: 54분

- 스크린샷 (선택)

@juyeon-park juyeon-park added the D-1 label Nov 7, 2023
@juyeon-park juyeon-park self-assigned this Nov 7, 2023
doggopawer
doggopawer approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@doggopawer doggopawer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네 주연님 업데이트 하시느라 고생하셨습니다.
제가 구현할 제안 확인 페이지에는 useDibs부분을 사용할 일은 없어 보이지만
6번 API에 경우 활용할 것으로 예상되어 , 나중에 만드신 목 API 에서 궁금한게 있으면 여쭤보도록 하겠습니다!

@juyeon-park juyeon-park merged commit 8121639 into develop Nov 8, 2023
2 checks passed
@juyeon-park juyeon-park deleted the NABI-156 branch November 8, 2023 06:52
doggopawer added a commit that referenced this pull request Nov 8, 2023
@doggopawer
Merge pull request #50 from team-nami/NABI-171
de8e84c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doggopawer doggopawer doggopawer approved these changes

@oaoong oaoong Awaiting requested review from oaoong

Assignees

@juyeon-park juyeon-park

Labels
D-1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juyeon-park @doggopawer