🎉 물건 조회 무한스크롤 로직 구현 #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oaoong
reviewed
Nov 5, 2023
Comment on lines
+13
to
+22
| const getItems = async ({ | ||
| category, | ||
| priceRange, | ||
| name, | ||
| status, | ||
| size, | ||
| cursorId, | ||
| }: GetItems) => { | ||
| const response = await apiClient.get(ApiEndPoint.items(cursorId)) | ||
| return response | ||
| return response.json() |
There was a problem hiding this comment.
response가 json 데이터를 반환하지 않을 경우 문제가 생길 수 있을 것 같아요. 공통으로 에러를 처리하던가 하는 논의를 해야겠군요!
There was a problem hiding this comment.
네 어떻게 처리할지, 한번 논의를 해보면 좋겠네요
There was a problem hiding this comment.
input에 대해서 validate하는 부분이 있을까요?
There was a problem hiding this comment.
input에 대한 검증 부분은 현재 진행 하고 있습니다. 일단 무한 스크롤 부분만 완료 했습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- 목적
관련 티켓 번호: 62
- 주요 변경 사항
기타 사항 (선택)
- 스크린샷 (선택)