🎉 ItemListPage 컴포넌트 UI 완성 #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oaoong
approved these changes
Nov 3, 2023
Comment on lines
10
to
21
| <svg | ||
| xmlns="http://www.w3.org/2000/svg" | ||
| className="h-5 w-5 text-gray-400" | ||
| viewBox="0 0 20 20" | ||
| fill="currentColor" | ||
| > | ||
| <path | ||
| fillRule="evenodd" | ||
| d="M9 16a7 7 0 100-14 7 7 0 000 14zm0 1a8 8 0 100-16 8 8 0 000 16zm5.293-11.293a1 1 0 00-1.414-1.414l-4 4a1 1 0 001.414 1.414l4-4z" | ||
| clipRule="evenodd" | ||
| /> | ||
| </svg> |
There was a problem hiding this comment.
요거는 SVG 파일로 저장하고 불러와서 사용하면 좋을 것 같습니다!
There was a problem hiding this comment.
현재 NABI-63(검색 로직 구현) 에서 해당 부분 고쳤습니다.
juyeon-park
reviewed
Nov 3, 2023
| @@ -0,0 +1,67 @@ | |||
| import Image from 'next/image' | |||
| @@ -0,0 +1,29 @@ | |||
| import React from 'react' | |||
| @@ -0,0 +1,19 @@ | |||
| import Image from 'next/image' | |||
There was a problem hiding this comment.
따로 컴포넌트화 해주신거 너무 좋네요! 감사합니다 👍
| const queryString = req.url.search | ||
| const cursorId = queryString.slice(10) | ||
| const currentPage = Number(cursorId) | ||
| const PAGE_SIZE = 5 |
There was a problem hiding this comment.
PAGE_SIZE 관련해서 카드 조회할때 이 데이터를 백엔드에 보내주는거 맞는지 다시 백엔드랑 확인해보는게 좋을 것 같아요! 만약 맞다면 msw가 조금 수정되어야 할 것 같아요! 이전 PR과 똑같은 내용입니다!
There was a problem hiding this comment.
넵넵, 슬랙으로 한번 물어봐야겠습니다.
oaoong
requested changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- 목적
관련 티켓 번호: 59
- 주요 변경 사항
기타 사항 (선택)
- 스크린샷 (선택)