Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐ŸŽ‰ ํ”„๋กœํ•„ ์˜์—ญ ์ปดํฌ๋„ŒํŠธ ๊ตฌํ˜„ #25

Merged
merged 5 commits into from
Nov 1, 2023

Conversation

juyeon-park
Copy link
Contributor

- ๋ชฉ์ 

๊ด€๋ จ ํ‹ฐ์ผ“ ๋ฒˆํ˜ธ: 85


- ์ฃผ์š” ๋ณ€๊ฒฝ ์‚ฌํ•ญ

  • ํ”„๋กœํ•„ ์˜์—ญ ์ปดํฌ๋„ŒํŠธ ๊ตฌํ˜„

๊ธฐํƒ€ ์‚ฌํ•ญ (์„ ํƒ)

  • ์ผ๋‹จ default ์ด๋ฏธ์ง€๋Š” shadcn์—์„œ ์ œ๊ณตํ•˜๋Š” ์ด๋ฏธ์ง€๋กœ ํ•ด๋†จ์Šต๋‹ˆ๋‹ค.
  • ํŽ˜์ด์ง€ ์ด๋ฆ„์ด๋‚˜ ์ปดํฌ๋„ŒํŠธ ์ด๋ฆ„ ๋” ์ข‹์€ ๊ฑฐ ์žˆ์œผ๋ฉด ์•Œ๋ ค์ฃผ์„ธ์š”!

- ์Šคํฌ๋ฆฐ์ƒท (์„ ํƒ)

image

@juyeon-park juyeon-park self-assigned this Nov 1, 2023
@juyeon-park juyeon-park added D-1 D-0 and removed D-1 labels Nov 1, 2023
Copy link
Collaborator

@oaoong oaoong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๐Ÿ‘

}

const ProfileSection = ({
profileImg = 'https://github.com/shadcn.png',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋”ฐ๋กœ ์ƒ์ˆ˜ํ™”ํ•ด์„œ ์‚ฌ์šฉํ•˜๋ฉด ์ข‹์„ ๊ฒƒ ๊ฐ™์•„์š”.
const DEFAULT_PROFILE_IMAGE = '~~' ์ด๋Ÿฐ ์‹์œผ๋กœ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avatar ์ปดํฌ๋„ŒํŠธ ์ž์ฒด์— default๋กœ ๋„ฃ์–ด๋†”๋„ ์ข‹์„ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์˜ค ๊ทธ๋ ‡๋„ค์š”!! avatar ์ปดํฌ๋„ŒํŠธ ์ž์ฒด์— ๋””ํดํŠธ๋กœ ํ•ด๋†“๊ฒ ์Šต๋‹ˆ๋‹ค! ํ˜น์‹œ ํ”„๋กœํ•„ ์ด๋ฏธ์ง€๋ฅผ ๋ฐ”๊ฟ€ ์ˆ˜๋„ ์žˆ์œผ๋‹ˆ๊นŒ ๋ชจ๋ฅด๋‹ˆ๊นŒ ์ƒ์ˆ˜ํ™”๋„ ํ•ด๋†“๊ฒ ์Šต๋‹ˆ๋‹ค

return (
<main className="flex-col min-h-screen bg-background-color">
<div>์ด๋ฏธ์ง€ ์Šฌ๋ผ์ด๋” ์˜์—ญ</div>
<ProfileSection userName="์ž„์‹œ์ด๋ฆ„" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ž„์‹œ profileImg ๋Š” ์ผ๋‹จ ๋นผ๋‘์‹ ๊ฑด๊ฐ€์š”?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์•— profileImg๊ฐ€ ๋น ์กŒ๊ตฐ์š”!! ๋ฐฑ์—”๋“œํŒ€๊ณผ ์–˜๊ธฐํ–ˆ์„ ๋•Œ ์ด๋ฏธ์ง€๊ฐ€ ์—†์„๋•Œ์—๋Š” ๋ฐฑ์—”๋“œ์—์„œ null๊ฐ’์œผ๋กœ ๋ฐ˜ํ™˜ํ•ด์ฃผ๋Š”๊ฑธ๋กœ ์–˜๊ธฐ๊ฐ€ ๋‚˜์™€์„œ null๋กœ ์˜ฌ๋•Œ๋„ ๋””ํดํŠธ ์ด๋ฏธ์ง€๊ฐ€ ๋ณด์ด๊ฒŒ ํ•ด๋†จ์Šต๋‹ˆ๋‹ค!

<Avatar size="md">
<AvatarImage src={profileImg} />
</Avatar>
<div className={`ml-9 ${TYPHOGRAPHY.profile}`}>{userName}</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sizes๋ฅผ ์ œ๊ฐ€ ์‚ฌ์šฉํ•˜์ž๊ณ  ์ œ์•ˆํ•˜๊ธด ํ–ˆ๋Š”๋ฐ ๋ง‰์ƒ ์ด๋ ‡๊ฒŒ ๋ณด๋‹ˆ, ๋ญ”๊ฐ€ tailwind์˜ ๋Š๋‚Œ์„ ํ•ด์น˜๋Š”๊ฒƒ ๊ฐ™์•„ ์šฐ๋ ค์Šค๋Ÿฝ๊ธฐ๋„ ํ•˜๋„ค์š”.
ํšŒ์˜๋ฅผ ํ†ตํ•ด ๊ด€๋ จํ•ด์„œ ์ •ํ•˜๋ฉด ์ข‹์„๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค.

Copy link
Collaborator

@oaoong oaoong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ํ…Œ์ŠคํŠธ์ฝ”๋“œ๋ฅผ ๋‹ค์‹œ ํ™•์ธํ•ด์ฃผ์„ธ์š”.

@oaoong oaoong closed this Nov 1, 2023
@juyeon-park juyeon-park reopened this Nov 1, 2023
@juyeon-park juyeon-park merged commit f90c855 into develop Nov 1, 2023
4 checks passed
@juyeon-park juyeon-park deleted the NABI-85 branch November 7, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants