🎉 2차 QA 스타일 수정 완료 #134
Merged
🎉 2차 QA 스타일 수정 완료 #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doggopawer
approved these changes
Nov 29, 2023
Comment on lines
24
to
29
| const cardData = data?.data | ||
|
|
||
| return ( | ||
| <main className="flex-col min-h-screen bg-background-color"> | ||
| {cardData && ( | ||
| <> |
There was a problem hiding this comment.
데이터가 없는 경우에 대한 처리라면 isEmpty 라는 변수명이 더 읽기 좋을 것 같습니다.
There was a problem hiding this comment.
흠 데이터가 없는 경우라기보다는 cardData가 무조건 있을때만 보이게 논리연산자를 통해 작성한 것이라 가독성에는 큰 문제가 없다고 생각하는데 변경하지 않아도 괜찮을까요??
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- 목적
관련 티켓 번호: 358
- 주요 변경 사항
기타 사항 (선택)
- 스크린샷 (선택)