🐛 찜 목록 연결 안되던 오류 해결 #101
Merged
🐛 찜 목록 연결 안되던 오류 해결 #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oaoong
reviewed
Nov 24, 2023
|
|
||
| const isEmpty = data?.pages[0].length === 0 | ||
| const MyDibsList = ({ | ||
| data, |
There was a problem hiding this comment.
data보단 다른 이름으로 처리해도 좋을 것 같아요!
Comment on lines
+57
to
+61
| getMyDibsList: ({ cursorId }: GetMyDibsReq) => | ||
| `/dibs/?${getQueryParams({ | ||
| cursorId, | ||
| size: COMMON_PAGE_SIZE, | ||
| })}`, |
There was a problem hiding this comment.
요거 함수 꼭 여기 안에서 써야하나요??
`/dibs/?${getQueryParams({
cursorId,
size: COMMON_PAGE_SIZE,
})}
자체를 cursorId 넣는 곳(사용처)에서 처리하면 좋을 것 같습니다
There was a problem hiding this comment.
좋은 의견 감사합니다. apiEndPoint는 문자열만 존재하는게 좋을 것 같네요.
doggopawer
approved these changes
Nov 24, 2023
Comment on lines
+57
to
+61
| getMyDibsList: ({ cursorId }: GetMyDibsReq) => | ||
| `/dibs/?${getQueryParams({ | ||
| cursorId, | ||
| size: COMMON_PAGE_SIZE, | ||
| })}`, |
There was a problem hiding this comment.
좋은 의견 감사합니다. apiEndPoint는 문자열만 존재하는게 좋을 것 같네요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- 목적
관련 티켓 번호: 300
- 주요 변경 사항
기타 사항 (선택)
- 스크린샷 (선택)