Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR] 지원서 조회하기와 관련된 API에 대한 리팩토링 #208

Merged
merged 6 commits into from
May 28, 2024
Merged

[REFACTOR] 지원서 조회하기와 관련된 API에 대한 리팩토링 #208

merged 6 commits into from
May 28, 2024

Conversation

shindong96
Copy link
Member

작업 내용

  • 지원서 조회에 관해 종료되지 않은 지원서들을 조회한다는 조건을 추가한다.

고려 사항

  • 지원서 모아보기의 경우 익숙하지 않아서 자세한 리뷰 부탁드립니다.

resolve #207

@shindong96 shindong96 requested a review from kyukong May 27, 2024 09:14
@shindong96 shindong96 self-assigned this May 27, 2024
kyukong
kyukong approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@kyukong kyukong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요 빠른 코드 반영 수고 많으셨습니다 👏🏻

QueryDsl 수정 부분도 확인해봤는데, 잘 해주신 것 같습니다.
다만 저희 둘 다 QueryDsl 은 익숙치 않기 때문에 isCompleted 부분만 테스트 코드를 작성하는건 어떨까요?

@shindong96
Copy link
Member Author

인수 테스트와 ApplicationRepositoryCustomImplTest는 추가했는데 혹시 어디 더 추가하길 바라시나요??

@kyukong
Copy link
Member

kyukong commented May 28, 2024

ApplicationRepositoryCustomImplTest 말씀드린거였는데, 다시 확인해보니 변경 코드가 많아서 안보여졌었네요! 작성하신 테스트 모두 확인했습니다! 👍

@shindong96 shindong96 merged commit 663c555 into develop May 28, 2024
1 check passed
@shindong96 shindong96 deleted the feature/#207/refactor-find-application branch May 28, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyukong kyukong kyukong approved these changes

Assignees

@shindong96 shindong96

Labels
🛠️ refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REFACTOR] 지원서 조회하기와 관련된 API에 대한 리팩토링
2 participants
@shindong96 @kyukong