[FEATURE] 스위치(완료 여부) 변경 기능 API 구현 #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyukong
approved these changes
May 7, 2024
| assertThat(response.getIsCompleted()).isEqualTo(request.getIsCompleted()); | ||
| } | ||
|
|
||
| @DisplayName("기존 상태로의 변경을 요청한다면 예외를 발생한다.") |
Comment on lines
20
to
28
| public Application(Long id, String companyName, String team, String location, String contact, String position, | ||
| String specificPosition, String jobDescription, String workType, EmploymentType employmentType, | ||
| String careerRequirement, String requiredCapability, String preferredQualification, Processes processes, | ||
| String url, Process currentProcess) { | ||
| String url, Process currentProcess, CompletedSwitch completedSwitch) { | ||
| super(id, companyName, team, location, contact, position, specificPosition, jobDescription, workType, | ||
| employmentType, careerRequirement, requiredCapability, preferredQualification, processes, url); | ||
| this.currentProcess = currentProcess; | ||
| this.completedSwitch = completedSwitch; | ||
| } |
| @Getter | ||
| public class CompletedSwitch { | ||
|
|
||
| private boolean isCompleted; |
There was a problem hiding this comment.
�객체에서 값을 변동할 수 있게 하는 방식으로 구현하고 싶었습니다! 그런데 저희가 이제껏 새로운 객체 반환으로 했던거 같네요ㅠㅠ이야기 해보아요ㅠ
| @@ -67,6 +69,13 @@ public ResponseEntity<GohigherResponse<Void>> updateSpecifically(@Login Long use | |||
| return ResponseEntity.ok(GohigherResponse.success(null)); | |||
| } | |||
|
|
|||
| @PatchMapping("/{applicationId}") | |||
There was a problem hiding this comment.
URI 가 /v1/applications/{applicationId} 인데 스위치 값 하나만 바꾸고 있습니당 포괄적인 URI 를 사용할 경우 나중에 기능이 확장되면 겹칠 가능성이 있어 보여요. URI 에 스위치 관련 정보를 넣으면 어떨까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 내용
isCompleted칼럼이 Application 테이블에 추가됩니다.주의 사항
isCompleted = false를 추가해야 합니다.resolve #200