Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merge: 데이터 암호화 구현 #493

Closed
wants to merge 13 commits into from
Closed

merge: 데이터 암호화 구현 #493

wants to merge 13 commits into from

Conversation

rlaisqls
Copy link
Member

@rlaisqls rlaisqls commented May 10, 2023 •
edited by ilyoil2
Loading

작업 내용 설명

  • kms를 이용한 데이터 암호화 구현

주요 변경 사항

  • kms Encrypt 구현 (참고)
  • 아직 일부 컬럼에만 적용해놓았고, 정렬 및 검색에 대한 대응방안은 마련하지 않았습니다
    • 어차피 paging이 적용되지 않았으니 조회해온 후에 정렬하는 방식을 생각중입니다..
    • 추후 추가 작업 예정입니다

결과물

첫 요청인 경우

  • encrypt X : 약 256ms
  • encrypt O : 약 1374ms

schoolSecret 캐시되어있는 경우

  • encrypt X : 약 86~105ms
  • encrypt O : 약 79~114ms

secret이 캐시되어있지 않은 경우 조회쿼리 + kms 요청으로 인해 반환에 1초 이상이 더 소요되지만, 캐시 된 경우에는 큰 차이 없는 것으로 보입니다

체크리스트

  • 어플리케이션 구동(혹은 테스트)시 오류는 없나요?
  • 생성된 코드에 Javadoc 주석을 추가 하였나요?
  • 생성된 코드에 대한 테스트 코드가 작성 되었나요?

관련 이슈

@rlaisqls rlaisqls self-assigned this May 10, 2023
@rlaisqls rlaisqls added the feat 새로운 기능을 추가 할 경우 label May 10, 2023
@rlaisqls rlaisqls marked this pull request as draft May 10, 2023 13:42
@sonarcloud
Copy link

sonarcloud bot commented May 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rlaisqls rlaisqls closed this Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@softpeanut softpeanut Awaiting requested review from softpeanut softpeanut is a code owner

@jeongyoon05 jeongyoon05 Awaiting requested review from jeongyoon05 jeongyoon05 is a code owner

@tedsoftj1123 tedsoftj1123 Awaiting requested review from tedsoftj1123 tedsoftj1123 is a code owner

@alsdl0629 alsdl0629 Awaiting requested review from alsdl0629 alsdl0629 is a code owner

Assignees

@rlaisqls rlaisqls

Labels
feat 새로운 기능을 추가 할 경우
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rlaisqls