Switch from os module to pathlib/Path for checking/removing test arti…

…fact files.
tdenewiler · Sep 3, 2024 · 3155731 · 3155731
1 parent b80f0e6
commit 3155731
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 12 deletions.
diff --git a/tests/chktex_tool_plugin/test_chktex_tool_plugin.py b/tests/chktex_tool_plugin/test_chktex_tool_plugin.py
@@ -5,6 +5,7 @@
 import pytest
 import subprocess
 import sys
+from pathlib import Path
 
 import statick_tool
 from statick_tool.config import Config
@@ -151,9 +152,11 @@ def test_chktex_tool_plugin_scan_oserror(mock_subprocess_check_output):
     issues = cttp.scan(package, "level")
     assert issues is None
 
-    try:
-        os.remove(os.path.join(os.getcwd(), "chktex.log"))
-    except FileNotFoundError as ex:
-        print(f"Error: {ex}")
-    except OSError as ex:
-        print(f"Error: {ex}")
+    log_file = Path("chktex.log")
+    if log_file.is_file():
+        try:
+            log_file.unlink()
+        except FileNotFoundError as ex:
+            print(f"Error: {ex}")
+        except OSError as ex:
+            print(f"Error: {ex}")
diff --git a/tests/lacheck_tool_plugin/test_lacheck_tool_plugin.py b/tests/lacheck_tool_plugin/test_lacheck_tool_plugin.py
@@ -5,6 +5,7 @@
 import pytest
 import subprocess
 import sys
+from pathlib import Path
 
 import statick_tool
 from statick_tool.config import Config
@@ -145,9 +146,11 @@ def test_lacheck_tool_plugin_scan_oserror(mock_subprocess_check_output):
     issues = ltp.scan(package, "level")
     assert issues is None
 
-    try:
-        os.remove(os.path.join(os.getcwd(), "lacheck.log"))
-    except FileNotFoundError as ex:
-        print(f"Error: {ex}")
-    except OSError as ex:
-        print(f"Error: {ex}")
+    log_file = Path("lacheck.log")
+    if log_file.is_file():
+        try:
+            log_file.unlink()
+        except FileNotFoundError as ex:
+            print(f"Error: {ex}")
+        except OSError as ex:
+            print(f"Error: {ex}")