Replace various sprintf with snprintf #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
seanm
force-pushed
the
snprintf
branch
2 times, most recently
from
a6a5325 to
c99ce89
Compare
tbeu
force-pushed
the
snprintf
branch
4 times, most recently
from
2208c66 to
2dcb770
Compare
tbeu
changed the title
|
@tbeu ah, I suppose this is to support old MS compilers, that did not support C99 properly? |
Exactly. AppVeyor (and my local VS setup) could not build your initial change. |
tbeu
force-pushed
the
snprintf
branch
2 times, most recently
from
a82d980 to
0e68c4a
Compare
snprintf is safer because the buffer length is specified, so can't be overrun.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
snprintf is safer because the buffer length is specified, so can't be overrun.