Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set RC file #225

Closed
wants to merge 1 commit into from
Closed

Set RC file #225

wants to merge 1 commit into from

Conversation

tbeu
Copy link
Owner

@tbeu tbeu commented Nov 21, 2023

No description provided.

@tbeu tbeu requested a review from MaartenBent November 21, 2023 21:54
@MaartenBent
Copy link
Collaborator

This is not necessary. The resource file is already added in

matio/cmake/src.cmake

Line 30 in 0884b80

${PROJECT_SOURCE_DIR}/visual_studio/matio.rc

You can verify it works by checking the details of the .dll properties. It sets the file description, copyright, and other fields.

@tbeu
Copy link
Owner Author

tbeu commented Nov 22, 2023

You are right, thanks!

@tbeu tbeu closed this Nov 22, 2023
@tbeu tbeu added the invalid label Nov 22, 2023
@tbeu tbeu removed the request for review from MaartenBent November 22, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
invalid
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tbeu @MaartenBent