-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nsis): uninstaller installdir reg clean up #12427
fix(nsis): uninstaller installdir reg clean up #12427
Conversation
Package Changes Through 17cf471There are 3 changes which include tauri-cli with patch, @tauri-apps/cli with patch, tauri-bundler with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually not a bug but rather a desired behavior, which saves the location and install language for future installations. I have seen this behavior countless times in other installers.
Since I saw installer language was removed on uninstall through What about we only do it if the "Delete the application data" gets checked? Probably makes sense to have everything cleaned up in that case (also in this case maybe we also move the delete language registry key?) |
That sounds fine |
Fix NSIS uninstaller not cleaning up
Software\${MANUFACTURER}\${PRODUCTNAME}
registry key used for the install location