Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nsis): uninstaller installdir reg clean up #12427

Merged
merged 3 commits into from
Jan 20, 2025

Conversation

Legend-Master
Copy link
Contributor

Fix NSIS uninstaller not cleaning up Software\${MANUFACTURER}\${PRODUCTNAME} registry key used for the install location

@Legend-Master Legend-Master requested a review from a team as a code owner January 17, 2025 04:44
Copy link
Contributor

github-actions bot commented Jan 17, 2025

Package Changes Through 17cf471

There are 3 changes which include tauri-cli with patch, @tauri-apps/cli with patch, tauri-bundler with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
tauri-bundler 2.2.2 2.2.3
@tauri-apps/cli 2.2.5 2.2.6
tauri-cli 2.2.5 2.2.6

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually not a bug but rather a desired behavior, which saves the location and install language for future installations. I have seen this behavior countless times in other installers.

@Legend-Master
Copy link
Contributor Author

Legend-Master commented Jan 17, 2025

Since I saw installer language was removed on uninstall through DeleteRegValue HKCU "${MANUPRODUCTKEY}" "Installer Language" before, I thought this was a bug instead of an intentional thing

What about we only do it if the "Delete the application data" gets checked? Probably makes sense to have everything cleaned up in that case (also in this case maybe we also move the delete language registry key?)

@amrbashir
Copy link
Member

That sounds fine

@amrbashir amrbashir merged commit b8eb288 into tauri-apps:dev Jan 20, 2025
14 checks passed
@Legend-Master Legend-Master deleted the nsis-cleanup-installdir-reg branch January 21, 2025 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants