-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add iOS frameworks config option, closes #9962 #10393
Conversation
Package Changes Through d4a1942There are 5 changes which include tauri-cli with prerelease, @tauri-apps/cli with prerelease, tauri with prerelease, tauri-plugin with prerelease, tauri-utils with prerelease Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI - cli fails should be an issue of time-rs
. It seemed to resolve the issue in 0.3.36
- sdk: UIKit.framework | ||
{{~#each ios-frameworks}} | ||
- sdk: {{this}}.framework{{/each}} | ||
|
||
- sdk: {{this}}.framework | ||
{{/each}} | ||
- sdk: WebKit.framework |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there's no framework provided, it'll be like:
- sdk: UIKit.framework - sdk: WebKit.framework
Played around, this one works for me:
- sdk: UIKit.framework{{#if this.ios-frameworks}}{{~#each ios-frameworks}}
- sdk: {{this}}.framework{{/each}}{{/if}}
- sdk: WebKit.framework
This one also fixs for ios-vendor-sdks
if there are multiple vendor-sdks. But since we don't support inserting ios-vendor-sdks
, this is minor
- framework: {{this}}
embed: false{{/each}}{{#if ios-vendor-frameworks}}{{~#each ios-vendor-frameworks}}
- framework: {{this}}{{/each}}{{/if}}{{#if ios-vendor-sdks}}{{~#each ios-vendor-sdks}}
- sdk: {{prefix-path this}}{{/each}}{{/if}}
- sdk: CoreGraphics.framework
- sdk: Metal.framework
- sdk: MetalKit.framework
- sdk: QuartzCore.framework
- sdk: Security.framework
- sdk: UIKit.framework{{#if this.ios-frameworks}}{{~#each ios-frameworks}}
- sdk: {{this}}.framework{{/each}}{{/if}}
- sdk: WebKit.framework
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch, thank you! pushed your fix
Just proposed #10407 to fix this issue |
- sdk: CoreGraphics.framework | ||
- sdk: Metal.framework | ||
- sdk: Metal.frameworks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it framework or frameworks 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea how i added this 😂 thanks
This was also drafted in #9992 |
No description provided.