reimplement find_bm() using std::search #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use std::search() to implement find_bm() instead of using a local implementation of Boyer-Moore. Avoids integer overflow reported in issue tat#31 and PR tat#31. Should fix build problem in issue tat#7. std::search is also faster for the test program in issue tat#31 on a system with an Intel Xeon E-2224 CPU: - gcc 8.5, find_bm(): 3.16s - g++ 8.5, std::search: 2.40s - g++ 13, std::search: 2.16s Experiments using the C++17 std::boyer_moore_searcher or std::boyer_moore_horspool_searcher were also slower than std::search in this experiment.
|
I've also previously submitted PR #30 that fixes various issues detected with newer g++ versions with -Wall -Werror. |
|
Before reimplementing with std::search, I experimented with other solutions including using the iterator's size_type instead of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use std::search() to implement find_bm() instead of using a local implementation of Boyer-Moore.
Avoids integer overflow reported in issue #32 and PR #31. Should fix build problem in issue #7.
std::search is also faster for the test program in issue #32 on a system with an Intel Xeon E-2224 CPU:
Experiments using the C++17 std::boyer_moore_searcher or std::boyer_moore_horspool_searcher were also slower than std::search in this experiment.