pkp/pkp-lib#10626 Add safety checks when displaying review rounds

taslangraham · Nov 28, 2024 · f517afc · f517afc
1 parent 14c7d53
commit f517afc
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/src/pages/workflow/composables/useWorkflowConfig/workflowConfigEditorialOJS.js b/src/pages/workflow/composables/useWorkflowConfig/workflowConfigEditorialOJS.js
@@ -269,7 +269,7 @@ export const WorkflowConfig = {
 					props: {
 						submission: submission,
 						stageId: pkp.const.WORKFLOW_STAGE_ID_EXTERNAL_REVIEW,
-						reviewRoundId: selectedReviewRound.id,
+						reviewRoundId: selectedReviewRound?.id,
 					},
 				});
 			}
@@ -298,7 +298,11 @@ export const WorkflowConfig = {
 			);
 
 			// if review stage has not started show no items
-			if (selectedReviewRound.round < currentReviewRound.round) {
+			if (
+				!selectedReviewRound ||
+				!currentReviewRound ||
+				selectedReviewRound.round < currentReviewRound.round
+			) {
 				return [];
 			}
 

diff --git a/src/pages/workflow/composables/useWorkflowConfig/workflowConfigEditorialOMP.js b/src/pages/workflow/composables/useWorkflowConfig/workflowConfigEditorialOMP.js
@@ -194,7 +194,7 @@ export const WorkflowConfig = {
 					props: {
 						submission: submission,
 						stageId: pkp.const.WORKFLOW_STAGE_ID_INTERNAL_REVIEW,
-						reviewRoundId: selectedReviewRound.id,
+						reviewRoundId: selectedReviewRound?.id,
 					},
 				});
 			}
@@ -218,7 +218,11 @@ export const WorkflowConfig = {
 			);
 
 			// if review stage has not started show no items
-			if (selectedReviewRound.round < currentReviewRound.round) {
+			if (
+				!selectedReviewRound ||
+				!currentReviewRound ||
+				selectedReviewRound.round < currentReviewRound.round
+			) {
 				return [];
 			}