feat(telemetry): metrics #2959
feat(telemetry): metrics #2959
Conversation
| @@ -1,30 +1,36 @@ | |||
| <!-- | |||
| Thank you for submitting a PR! | |||
| Thank you for submitting a PR! | |||
There was a problem hiding this comment.
Please make sure to not reformat unrelated files.
| * [v3](changelogs/changelog-v3.md) | ||
| * [v2](changelogs/changelog-v2.md) | ||
| * [v1](changelogs/changelog-v1.md) | ||
| - [What is BullMQ](README.md) |
There was a problem hiding this comment.
Do not reformat unrelated files.
| import { SpanKind, ValueType } from '../enums'; | ||
|
|
||
| /** | ||
| * Configuration for bullmqOtel package. |
There was a problem hiding this comment.
Even though this will be now used by the bullmq-otel package, it is should not be specifically for this package.
| * Configuration for bullmqOtel package. | ||
| * Used for tracing and metrics. | ||
| */ | ||
| export interface Configuration { |
There was a problem hiding this comment.
Configuration is a way too generic name for an interface.
There was a problem hiding this comment.
I could not find where Configuration is used in the code, so what is its purpose?
| flow.queueName, | ||
| 'addFlow', | ||
| flow.queueName, | ||
| return telemetry<Promise<JobNode>>( |
There was a problem hiding this comment.
I am very confused about this name change, now we have both a telemetry object and a telemetry function. Besides, the best practice is to name functions as verbs, and in this case it is a substantive, so it is not clear what the function does by its name alone.
No description provided.