docs: provide connection details in getting started (fixes #2838) #2897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgozdz
changed the title
roggervalf
changed the title
roggervalf
requested changes
Nov 12, 2024
| @@ -25,7 +25,7 @@ const myWorker = new Worker('myqueue', async (job)=>{}, { connection: { | |||
| import { Queue, Worker } from 'bullmq'; | |||
| import IORedis from 'ioredis'; | |||
|
|
|||
| const connection = new IORedis(); | |||
| const connection = new IORedis({ maxRetriesPerRequest: null }); | |||
There was a problem hiding this comment.
something to take in count is that we are recommending to not add this option for producers (Queue), only for consumers (Workers). Pls change it to reflect it base on https://docs.bullmq.io/bull/patterns/persistent-connections#queue
fgozdz
force-pushed
the
docs/connection-details-in-getting-started
branch
from
43a6bf5 to
8643147
Compare
manast
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue fixes #2838