perf(worker): use abort controller with stalledCheckTimer #2509
Conversation
src/classes/worker.ts
Outdated
| this.stalledCheckTimer = setTimeout(async () => { | ||
| await this.startStalledCheckTimer(); | ||
| }, this.opts.stalledInterval); | ||
| const callback = async () => { |
There was a problem hiding this comment.
I am a bit confused about using the same callback for the timeout as well as for the abort signal. I think abort should only do abort and nothing else.
There was a problem hiding this comment.
There was a problem hiding this comment.
yes but there is a slight difference, in the delay case the callback is actually a "cleanup" function, but here the callback is both cleanup and starting a new timer. So I think in this case it will be better to refactor to a "cleaup" function that can be used only for the abort signal, and that is also called inside the current callback.
There was a problem hiding this comment.
I think I overlooked this, as I can see that we are cleaning the timer here https://github.com/taskforcesh/bullmq/blob/master/src/classes/worker.ts#L869
Draft