Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use base repo for project name in github .taskcluster.yml template #610

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

bhearsum
Copy link
Contributor

@bhearsum bhearsum commented Dec 6, 2024

project name is mainly used in routes, which require specific scopes to be set. Because of this, we should always use the base version of this. In cases where the head repository has a different name this ends up breaking things like actions in PRs.

project name is mainly used in routes, which require specific scopes to be set. Because of this, we should always use the `base` version of this. In cases where the `head` repository has a different name this ends up breaking things like actions in PRs.
Copy link
Contributor

@jcristau jcristau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider making that same change in taskgraph's own .taskcluster.yml?

@bhearsum bhearsum merged commit 33803c5 into taskcluster:main Dec 6, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants