Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't assume the proxy is running on http://taskcluster #603

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

Eijebong
Copy link
Contributor

This fixes the two places where taskgraph assumed the proxy would be running on http://taskcluster instead of looking at the TASKCLUSTER_PROXY_URL environment variable.

This fixes the two places where taskgraph assumed the proxy would be
running on `http://taskcluster` instead of looking at the
`TASKCLUSTER_PROXY_URL` environment variable.
Copy link
Collaborator

@ahal ahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'd like to strip trailing slashes first because someone is inevitably going to add a trailing slash

src/taskgraph/create.py Outdated Show resolved Hide resolved
src/taskgraph/run-task/run-task Outdated Show resolved Hide resolved
Copy link
Collaborator

@ahal ahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ahal ahal merged commit a37236a into taskcluster:main Oct 29, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants