Consolidate uv version + add it to run-task image
#581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This approach does set the arg for all images even though many of them don't need it. But it's a no-op in this case, so this isn't really an issue.
`run-task` now has a feature where it will use `uv` to install pip packages, so it makes sense to include `uv` here as well. Note the Decision image uses `run-task` as a base, so this is *not* removing `uv` from there.
bhearsum
approved these changes
Oct 7, 2024
| # Keep uv version in sync with decision image | ||
| COPY --from=ghcr.io/astral-sh/uv:0.4.9 /uv /bin/uv | ||
| # %ARG UV_VERSION | ||
| COPY --from=ghcr.io/astral-sh/uv:$UV_VERSION /uv /bin/uv |
There was a problem hiding this comment.
TIL you can copy from images outside of your own build. Neat.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.