Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: change 'root_dir' to point to main 'taskcluster' directory #376

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

ahal
Copy link
Collaborator

@ahal ahal commented Dec 4, 2023

BREAKING CHANGE: root dir should now point to the 'taskcluster' dir rather than 'taskcluster/kinds'.

This only impacts projects that use taskgraph.config.load_graph_config or taskgraph.generator.TaskGraphGenerator directly.

@ahal ahal added the BREAKING CHANGE Backwards incompatible request that will require major version bump label Dec 4, 2023
@ahal ahal requested a review from a team December 4, 2023 16:56
@ahal ahal self-assigned this Dec 4, 2023
@ahal ahal requested a review from hneiva December 4, 2023 16:56
@ahal
Copy link
Collaborator Author

ahal commented Dec 4, 2023

I debated whether this should truly be considered a breaking change or not, but given we are about to do a major bump, might as well err on the side of caution.

BREAKING CHANGE: root dir should now point to the 'taskcluster' dir
rather than 'taskcluster/kinds'.

This only impacts projects that use `taskgraph.config.load_graph_config`
or `taskgraph.generator.TaskGraphGenerator` directly.
Copy link
Contributor

@jcristau jcristau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ahal ahal merged commit 6ab628c into taskcluster:main Dec 5, 2023
7 checks passed
@ahal ahal deleted the root_dir branch December 5, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGE Backwards incompatible request that will require major version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants