Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Grafana and Prometheus to the Docker Compose file #10

Merged
merged 1 commit into from
Nov 25, 2023

Conversation

madflojo
Copy link
Member

@madflojo madflojo commented Nov 25, 2023

This PR adds Grafana and Prometheus along with a sample dashboard.

Summary by CodeRabbit

  • Chores

    • Updated service names and commands in the Makefile for improved clarity and background execution.
  • Documentation

    • Enhanced the README with instructions for accessing the new dashboard and monitoring application metrics. Provided login credentials for user convenience.

Copy link
Contributor

coderabbitai bot commented Nov 25, 2023

Walkthrough

The recent updates involve a renaming of a service in the Makefile from airport-lookup-example to example and an enhancement in the README.md to include details on accessing a new dashboard for monitoring application metrics. The dashboard is accessible locally with provided admin credentials and sources its data from the /metrics endpoint.

Changes

File Changed Summary of Changes
Makefile Renamed the airport-lookup-example service to example and updated the command to run the service in detached mode.
README.md Added instructions for accessing a new monitoring dashboard at localhost:3000 and provided login credentials.

🐇 A hop, a skip, a code deploy, 🚀
Renaming services, oh what joy!
A dashboard new, for metrics to view,
With admin access, for the monitoring crew.
In the README, find your clue, 🔍
To watch the data as it grew.
A rabbit's work, now neatly through,
Celebrate with a carrot stew! 🥕


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Copy link

codecov bot commented Nov 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5974992) 92.92% compared to head (31a770b) 92.92%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #10   +/-   ##
=======================================
  Coverage   92.92%   92.92%           
=======================================
  Files           2        2           
  Lines          99       99           
=======================================
  Hits           92       92           
  Misses          5        5           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@madflojo madflojo merged commit 523821e into tarmac-project:main Nov 25, 2023
5 checks passed
@madflojo madflojo deleted the metrics branch November 25, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant