feat!: remove coinbases from weight calculations

[SWvheerden]

Description

removes coinbases from the weight calculations making calculations regarding weight simpler.
Adds max coinbase constant, currently 1000.

Motivation and Context

This will simplify the mining and verification of coinbases and weights, by making coinbases not count towards block weight.

How Has This Been Tested?

unit tests

[github-actions]

Test Results (CI)

    3 files    129 suites   40m 12s ⏱️
1 351 tests 1 351 ✅ 0 💤 0 ❌
4 051 runs  4 051 ✅ 0 💤 0 ❌

Results for commit 62933e2.

♻️ This comment has been updated with latest results.

[github-actions]

Test Results (Integration tests)

18 tests   18 ✅  6m 46s ⏱️
 2 suites   0 💤
 2 files     0 ❌
 1 errors

For more details on these parsing errors, see this check.

Results for commit 62933e2.

♻️ This comment has been updated with latest results.

[hansieodendaal]

I think we need to verify that the maximum block size of 4MB for comms purposes will still be adhered to when we have full blocks with say 1000 coinbases in the block. When we get a new block template for mining this limitation must be taken into account, and not only discovered when we try to transmit such a mined block.

[SWvheerden]

Good point about the comms block size,
I increased this to 6MB to ensure its still safe. 2MB should be more than safe for 1000 coinbases
That 4MB limit is just a value to ensure that no one can keep streaming bytes to the receiver endlessly and fill the memory.

[hansieodendaal]

utACK