Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: sort completed transactions #6733

Draft
wants to merge 7 commits into
base: development
Choose a base branch
from

Conversation

mmrrnn
Copy link
Contributor

@mmrrnn mmrrnn commented Jan 7, 2025

Description

Sort transactions in get_completed_transactions response.

Motivation and Context

Current implementation doesn't allow to fetch only part of all transactions(i.e last 10 txs).

How Has This Been Tested?

manually

@mmrrnn mmrrnn marked this pull request as draft January 7, 2025 14:57
Copy link

github-actions bot commented Jan 7, 2025

Test Results (CI)

    2 files     86 suites   23m 19s ⏱️
1 349 tests 1 349 ✅ 0 💤 0 ❌
2 698 runs  2 698 ✅ 0 💤 0 ❌

Results for commit d06e9fe.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jan 7, 2025

Test Results (Integration tests)

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit d06e9fe. ± Comparison against base commit 16fb40c.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@SWvheerden SWvheerden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not do an order here in rust.
I would change it where it gets it from the database and use SQL to to do the order.

Also don't order by timestamp, order by mined_timestamp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants